Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created layout preset library (#375) #383

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Atria1234
Copy link
Collaborator

@Atria1234 Atria1234 commented Dec 3, 2021

First step:

  • Add translations
  • Find final place for the dialog button in the menu
  • Find good way to show layout preset images
  • Make Layout folder location configurable

Next step:

  • Implement synchronization of layout presets from somewhere (github repo probably)

@Atria1234 Atria1234 force-pushed the feature/add-preset-layout-library branch from 18124af to ff51152 Compare December 18, 2021 13:55
@Atria1234
Copy link
Collaborator Author

Atria1234 commented Dec 18, 2021

To test:

  • There should be "Layouts" folder in folder with AnnoDesigner.exe
  • Create arbitrary folder structure in that folder, if you want
  • Put zip files into any subfolder in "Layouts" folder. Content of that zip file:
    • layout.ad (has to be named like that)
    • info.json (has to be named like that), for structure, check JSON schema in Layouts/LayoutInfoSchema.json file
    • any *.png, *.jpg or *.jpeg image files which should be attached to that layout

Same info is also available in Layouts/Readme.md

@StingMcRay
Copy link
Contributor

There should be "Layouts" folder in folder with AnnoDesigner.exe

Is this only for the purpose of the fix and will this default?
If is, then i want to request that this folder can be changed as default to other drives/locations
settings wise

@Atria1234
Copy link
Collaborator Author

You mean that root layout preset folder should be configurable somewhere by the user?

@StingMcRay
Copy link
Contributor

In anyway the Layouts Directory, rest ofc is default Program directory

I have as example my Exe on C, but my layouts on D
(if windows crashing, i do not lose my Layouts, and the Program is easy to download :D)

@Atria1234
Copy link
Collaborator Author

Added to tasks

@Atria1234 Atria1234 force-pushed the feature/add-preset-layout-library branch from ff51152 to 296247c Compare December 23, 2021 15:05
@Atria1234 Atria1234 force-pushed the feature/add-preset-layout-library branch from 296247c to a07f581 Compare January 17, 2022 15:20
@Atria1234 Atria1234 force-pushed the feature/add-preset-layout-library branch from a07f581 to 7e8a94a Compare June 20, 2022 11:47
- fixed some memory leaks
- reduced memory requirements
@Atria1234
Copy link
Collaborator Author

I'm aware there is a lot of conflicts, I'll fix those if you think this is good way of going forward with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants