Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Repositories Unit Testable #21

Open
Annonator opened this issue Dec 29, 2021 · 3 comments
Open

Make Repositories Unit Testable #21

Annonator opened this issue Dec 29, 2021 · 3 comments
Assignees
@steffigro
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Annonator
Copy link
Owner

Right now, the repositories can't be tested as they have a File IO dependencies. In order to make it test able we need an abstraction / wrapper to be able to mock file IO in our unit tests.
@Annonator Annonator added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 29, 2021
@Annonator Annonator mentioned this issue Jan 30, 2022
Closed
@steffigro steffigro self-assigned this Feb 2, 2022
@Structed
Copy link
Collaborator

Structed commented Feb 6, 2022

This also relates to PlayFab API calls - those are currently only very difficult to test.
Current players commands currently use the static PlayFab API clients, instead of the instance API.

See #52 for an example on using the instance API.

@Annonator
Copy link
Owner Author

Let's focus on making the local repository testable for a start in this Issue :)

@Structed
Copy link
Collaborator

Structed commented Feb 7, 2022

Let's focus on making the local repository testable for a start in this Issue :)

Jup, just mentioning :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steffigro steffigro

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Structed @Annonator @steffigro