-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable expressions: undefined -> null #2
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
76451c8
Changes undefined -> null.
carterzenk 7a2979c
refactors tests
carterzenk 539c138
fixes select test.
carterzenk f9f9a35
Remove separate type for CapturingResultSet. It makes the resulting …
carterzenk e35ff0c
Refactor result set again, use an expand helper to resolve types.
carterzenk 3559198
fix tests
carterzenk e9d0607
Remove unused dependencies.
carterzenk feb278e
Merge branch 'main' of github.com:Anrok/mammoth into v1
carterzenk 6b2c3c6
Add back in ability to choose whether default is always setting a val…
carterzenk 274e1fd
fix
carterzenk 811e41b
fix indent
carterzenk 95ee1b0
feedback
carterzenk d5cbcb2
feedback
carterzenk 3d7d9a9
fix indent
carterzenk e0ecb54
Merge remote-tracking branch 'origin/main' into v1
cakoose 9fc1660
Run Prettier
cakoose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old code used
__tests__
and__checks__
folders. Can we keep that structure or is that hard?(If we're starting out with the hope that this fork goes away eventually, it might be nice to avoid unnecessary changes.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this for less ignore configuration in these files, but if you'd prefer I can switch it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think I'd prefer to leave it unchanged in this case, to stay close to the upstream code.
(I don't think that's always the right answer, e.g. changing the type testing library like a change that's worth it.)