Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable expressions: undefined -> null #2

Merged
merged 16 commits into from
Oct 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ This is a fork of [@ff00ff/mammoth](https://github.com/Ff00ff/mammoth). We made

This fork is based on the 1.x version rather than newer 2.x version. We made this decision because the 2.x version is still in alpha, and we ran into memory issues during TS compilation in the probject we were using it for. We start from [c7c525c978aa6326042b35ca95f93699a69370c5](https://github.com/Anrok/mammoth/commit/c7c525c978aa6326042b35ca95f93699a69370c5) because that is the last commit before the big 2.x refactor.

[List of changes](https://github.com/Anrok/mammoth/compare/main...c7c525c978aa6326042b35ca95f93699a69370c5)
### List of changes ([commits](https://github.com/Anrok/mammoth/compare/main...c7c525c978aa6326042b35ca95f93699a69370c5))
- Changes nullable expressions to use the `null` data type, rather than `undefined`.

---

Expand Down
3,436 changes: 2,241 additions & 1,195 deletions package-lock.json

Large diffs are not rendered by default.

54 changes: 35 additions & 19 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
".build"
],
"devDependencies": {
"@tsd/typescript": "^5.2.2",
"@types/jest": "^26.0.24",
"@types/node": "^16.4.10",
"dts-jest": "^23.3.0",
"jest": "^26.6.3",
"jest-runner-tsd": "^6.0.0",
"prettier": "^3.0.3",
"ts-jest": "^26.5.6",
"typescript": "^4.3.5"
Expand All @@ -35,23 +36,38 @@
"prepublishOnly": "npm run build && npm test"
},
"jest": {
"moduleFileExtensions": [
"ts",
"js"
],
"coveragePathIgnorePatterns": [
"__tests__",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code used __tests__ and __checks__ folders. Can we keep that structure or is that hard?

(If we're starting out with the hope that this fork goes away eventually, it might be nice to avoid unnecessary changes.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this for less ignore configuration in these files, but if you'd prefer I can switch it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I'd prefer to leave it unchanged in this case, to stay close to the upstream code.

(I don't think that's always the right answer, e.g. changing the type testing library like a change that's worth it.)

"__checks__"
],
"testPathIgnorePatterns": [
"/\\.build/",
"/node_modules/",
"helpers"
],
"testRegex": "/__tests__|__checks__/.*\\.(test|check)\\.ts$",
"transform": {
"\\.check\\.ts$": "dts-jest/transform",
"\\.ts$": "ts-jest"
}
"projects": [
{
"displayName": "unit",
"moduleFileExtensions": [
"ts",
"js"
],
"coveragePathIgnorePatterns": [
"__tests__",
"__checks__"
],
"testPathIgnorePatterns": [
"/\\.build/",
"/node_modules/",
"helpers"
],
"testMatch": ["**/__tests__/*.test.ts"],
"transform": {
"\\.ts$": "ts-jest"
},
"reporters": [
"default"
]
},
{
"displayName": {
"color": "blue",
"name": "types"
},
"runner": "jest-runner-tsd",
"testMatch": ["**/__checks__/*.check.ts"]
}
]
}
}
3 changes: 0 additions & 3 deletions src/__checks__/__snapshots__/data-types.check.ts.snap

This file was deleted.

7 changes: 0 additions & 7 deletions src/__checks__/__snapshots__/delete.check.ts.snap

This file was deleted.

40 changes: 0 additions & 40 deletions src/__checks__/__snapshots__/insert.check.ts.snap

This file was deleted.

54 changes: 0 additions & 54 deletions src/__checks__/__snapshots__/select.check.ts.snap

This file was deleted.

5 changes: 0 additions & 5 deletions src/__checks__/__snapshots__/truncate.check.ts.snap

This file was deleted.

11 changes: 0 additions & 11 deletions src/__checks__/__snapshots__/update.check.ts.snap

This file was deleted.

Loading