This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Fix tests on Windows #212
Merged
Fix tests on Windows #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest we keep this open until #208 is merged so we can confirm those tests pass... |
mikelik
force-pushed
the
mikelik/fix_windows
branch
from
7015c84
to
c620a4d
Compare
…ner: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "exit": executable file not found in $PATH: unknown"
ScottBailey
approved these changes
Jun 7, 2023
pliuwu1998
approved these changes
Jun 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #186
The only failing tests are:
which will stop failing after #202 is done.
Unfortunately it is not possible to add Windows to CI or run Windows tests (because of #186 (comment))