Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Fix failing test_project.py - merge to main #87

Closed
wants to merge 10 commits into from

Conversation

mikelik
Copy link
Contributor

@mikelik mikelik commented Dec 14, 2022

Stop container before removing TEST_APP_DIR to release the open file handles.
This way removing TEST_APP_DIR is completed before starting another test.

@mikelik mikelik self-assigned this Dec 14, 2022
@mikelik mikelik linked an issue Dec 14, 2022 that may be closed by this pull request
@jolly-fellow
Copy link
Contributor

I don't understand why "Fix failing test_project.py" rewrites ALL files which takes to the functional tests?
It destroys history of changes and doesn't allow to see what was really changed.
Please leave only actual changes in the PR.

@mikelik mikelik changed the title Fix failing test_project.py Fix failing test_project.py - merge to main Dec 16, 2022
@mikelik
Copy link
Contributor Author

mikelik commented Dec 16, 2022

I don't understand why "Fix failing test_project.py" rewrites ALL files which takes to the functional tests? It destroys history of changes and doesn't allow to see what was really changed. Please leave only actual changes in the PR.

This PR is based on #79.
I hoped PR79 would be already merged to main so in this PR only my changes would remain.
I have created a PR with fixes to functional-test branch here: #88.

@mikelik mikelik closed this Dec 16, 2022
@mikelik mikelik deleted the mikelik/fix-test_project branch December 16, 2022 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DUNE test test_project.py fails
3 participants