Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Use empty() instead of NULL_BLOCK_ID, NULL_PROPOSAL_ID #1545

Closed
Tracked by #1508
heifner opened this issue Aug 22, 2023 · 1 comment · Fixed by #1566
Closed
Tracked by #1508

IF: Use empty() instead of NULL_BLOCK_ID, NULL_PROPOSAL_ID #1545

heifner opened this issue Aug 22, 2023 · 1 comment · Fixed by #1566
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Aug 22, 2023 •
edited
Loading

Needs to be done before release because it affects what is transferred across the network.
@heifner heifner mentioned this issue Aug 22, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Aug 23, 2023
@heifner heifner self-assigned this Aug 26, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Aug 26, 2023
heifner added a commit that referenced this issue Aug 26, 2023
@heifner
GH-1545 Remove NULL_BLOCK_ID and NULL_PROPOSAL_ID and use empty() ins…
33ac700 
…tead
@heifner heifner mentioned this issue Aug 26, 2023
Merged
@heifner heifner linked a pull request Aug 26, 2023 that will close this issue
IF: Remove NULL_BLOCK_ID & NULL_PROPOSAL_ID and use empty() #1566
Merged
heifner added a commit that referenced this issue Aug 26, 2023
@heifner
GH-1545 Prefer {} to block_id_type{}
dd18c2f
heifner added a commit that referenced this issue Aug 29, 2023
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-1545…
2a94c27 
…-empty-id
heifner added a commit that referenced this issue Aug 29, 2023
@heifner
Merge pull request #1566 from AntelopeIO/GH-1545-empty-id
f8e3dea 
IF: Remove NULL_BLOCK_ID & NULL_PROPOSAL_ID and use empty()
@heifner
Copy link
Member Author

heifner commented Aug 29, 2023

Completed by #1566

@heifner heifner closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: Remove NULL_BLOCK_ID & NULL_PROPOSAL_ID and use empty() AntelopeIO/leap
3 participants
@heifner @arhag @enf-ci-bot