Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore: add exclusion for scripts/pinned_toolchain.cmake #1361

Closed
wants to merge 1 commit into from

Conversation

cc32d9
Copy link
Contributor

@cc32d9 cc32d9 commented Jul 3, 2023

the *.cmake wildcard in gitignore covers scripts/pinned_toolchain.cmake which should not be ignored.

@Parth2412
Copy link

You need to add an exclusion for one another file as well,
File Name: switch_stack_linux.s
File Path: ./libraries/chain/webassembly/runtimes/eos-vm-oc/switch_stack_linux.s

in the .gitignore file there is an extension added *.s.

@heifner
Copy link
Member

heifner commented Jul 27, 2023

You need to add an exclusion for one another file as well, File Name: switch_stack_linux.s File Path: ./libraries/chain/webassembly/runtimes/eos-vm-oc/switch_stack_linux.s

in the .gitignore file there is an extension added *.s.

Thanks @Parth2412, created issue #1457 for this.

@greg7mdp
Copy link
Contributor

Why do we have a *.cmake exclusion?

@greg7mdp
Copy link
Contributor

I opened an alternative PR #1460 which removes the *.cmake exclusion.

@greg7mdp
Copy link
Contributor

Closing as superseded by PR #1460.

@greg7mdp greg7mdp closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants