[PH] Create workflow for manually dispatching performance harness runs #1378
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,16 @@ name: "Performance Harness Run" | |
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| platform-choice: | ||
| description: 'Override build platform' | ||
| type: choice | ||
| options: | ||
| - ubuntu20 | ||
| - ubuntu22 | ||
| override-test-params: | ||
| description: 'Override perf harness params' | ||
| type: string | ||
|
|
||
| permissions: | ||
| packages: read | ||
|
|
@@ -12,10 +22,102 @@ defaults: | |
| shell: bash | ||
|
|
||
| jobs: | ||
|
|
||
| v: | ||
| name: Discover Inputs | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| test-params: ${{steps.overrides.outputs.test-params}} | ||
| steps: | ||
| - name: Setup Input Params | ||
| id: overrides | ||
| env: | ||
| GH_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
|
|
||
| run: | | ||
| echo test-params=testBpOpMode >> $GITHUB_OUTPUT | ||
|
|
||
| if [[ "${{inputs.override-test-params}}" != "" ]]; then | ||
| echo test-params=${{inputs.override-test-params}} >> $GITHUB_OUTPUT | ||
| fi | ||
|
|
||
| platforms: | ||
| name: Run Platforms Workflow | ||
| uses: ./.github/workflows/platforms.yaml | ||
| with: | ||
| override-build-matrix: ${{github.event.inputs.platform-choice}} | ||
| permissions: | ||
| packages: write | ||
| contents: read | ||
|
|
||
| reuse-build: | ||
| name: Reuse leap build | ||
| needs: [v] | ||
| if: | | ||
| always() && | ||
| needs.v.result == 'success' | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| build-artifact: ${{steps.downloadBuild.outputs.downloaded-file}} | ||
| steps: | ||
| - name: Download builddir | ||
| id: downloadBuild | ||
| uses: AntelopeIO/asset-artifact-download-action@v3 | ||
| with: | ||
| owner: AntelopeIO | ||
| repo: leap | ||
| file: build.tar.zst | ||
| target: ${{github.sha}} | ||
| artifact-name: ${{github.event.inputs.platform-choice}}-build | ||
| fail-on-missing-target: false | ||
| token: ${{github.token}} | ||
|
There was a problem hiding this comment. with |
||
|
|
||
| - name: Upload builddir | ||
| if: steps.downloadBuild.outputs.downloaded-file != '' | ||
| uses: AntelopeIO/upload-artifact-large-chunks-action@v1 | ||
| with: | ||
| name: ${{github.event.inputs.platform-choice}}-build | ||
| path: build.tar.zst | ||
|
There was a problem hiding this comment. Similar comments as #1356 (comment): we shouldn't be copy pasting all of this, we need to come up with a better approach. There was a problem hiding this comment. @spoonincode - I have refactored the build to be a reusable workflow in PR#1356. Hoping to have that PR go into |
||
|
|
||
| build-base: | ||
| name: Run Build Workflow | ||
| needs: [platforms, reuse-build] | ||
| if: always() && needs.platforms.result == 'success' && needs.reuse-build.outputs.build-artifact == '' | ||
| uses: ./.github/workflows/build_base.yaml | ||
| with: | ||
| p: ${{needs.platforms.outputs.p}} | ||
| platform-matrix: ${{needs.platforms.outputs.platform-matrix}} | ||
| permissions: | ||
| packages: write | ||
| contents: read | ||
|
|
||
| tests: | ||
| name: Tests | ||
| needs: [v, platforms, reuse-build, build-base] | ||
| if: always() && needs.platforms.result == 'success' && (needs.build-base.result == 'success' || needs.reuse-build.result == 'success') | ||
|
There was a problem hiding this comment. we really need to find a way to get #283 in good shape to avoid these tricky |
||
| runs-on: ubuntu-latest | ||
|
There was a problem hiding this comment. This means it runs on a github owned runner, is that what you wanted? There was a problem hiding this comment. @spoonincode - Correct. I was using the github owned runner for initial testing and verification of the workflow. Now that this is closer to complete, do you have a suggestion for a runner to use ( |
||
| container: | ||
| image: ${{fromJSON(needs.platforms.outputs.p)[github.event.inputs.platform-choice].image}} | ||
| steps: | ||
| - name: Download builddir | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: ${{github.event.inputs.platform-choice}}-build | ||
| - name: Run Performance Test | ||
| run: | | ||
| zstdcat build.tar.zst | tar x | ||
| cd build | ||
| ./tests/performance_tests/performance_test.py ${{needs.v.outputs.test-params}} | ||
| - name: Prepare results | ||
| id: prep-results | ||
| run: | | ||
| tar -pc build/performance_test | zstd --long -T0 -9 > performance_test_logs.tar.zst | ||
| - name: Upload results | ||
| uses: AntelopeIO/upload-artifact-large-chunks-action@v1 | ||
| with: | ||
| name: performance-test-results | ||
| path: performance_test_logs.tar.zst | ||
| - name: Upload report | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: performance-test-report | ||
| path: ./build/performance_test/**/report.json | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this isn't really overriding the platform but rather picking which platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Here it is a platform selection, however down in
platforms.yamlit serves to override the auto-generated platform matrix (fromplatforms.json). I'll update the verbiage here. Addressed: 8c47cce