Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Add thread safety to chain_pacemaker access of chain state #1574

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 28, 2023

Connect chain_pacemaker to controller accepted_block signal.
Protect access to cached chain_pacemaker chain state via a mutex.

Resolves #1541 Part 2/2 See #1550 for Part 1/2.

@heifner heifner added the OCI Work exclusive to OCI team label Aug 28, 2023
@heifner heifner linked an issue Aug 28, 2023 that may be closed by this pull request
@heifner heifner requested a review from greg7mdp August 28, 2023 18:41
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/hotstuff/chain_pacemaker.cpp Show resolved Hide resolved
libraries/hotstuff/chain_pacemaker.cpp Show resolved Hide resolved
@greg7mdp
Copy link
Contributor

I think you can merge this one.

@heifner heifner merged commit 9b6fbdc into hotstuff_1511_hostfn Aug 29, 2023
22 checks passed
@heifner heifner deleted the GH-1541-threading-part-2 branch August 29, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: Fix threading issues in qc_chain & chain_pacemaker
3 participants