Rename block_header_state and block_state to block_header_state_legacy and block_state_legacy in preparation for Instant Fininality #1951
Conversation
…, cpp} and rename block_state.{hpp,cpp} to block_state_legacy.{hpp,cpp}
…ock_header_state_legacy
libraries/chain/include/eosio/chain/block_header_state_legacy.hpp
Outdated
Show resolved
Hide resolved
No problem. Happy it is the best for our work! |
| signal<void(const block_state_ptr&)> irreversible_block; | ||
| signal<void(const block_state_legacy_ptr&)> accepted_block_header; | ||
| signal<void(const block_state_legacy_ptr&)> accepted_block; | ||
| signal<void(const block_state_legacy_ptr&)> irreversible_block; |
There was a problem hiding this comment.
This is unfortunate. In hotstuff_integration branch this will need to be a std::variant of the two types.
There was a problem hiding this comment.
Actually, I think we should change these signals to signal signed_block_ptr, block_id instead of block_state_legacy_ptr. I think that should be done either in main and merged to hotstuff_integration or done in hotstuff_integration.
There was a problem hiding this comment.
Should we do this in hotstuff_integration after merging main into it, as you have approved the PR?
There was a problem hiding this comment.
Although, third-party plugins would need to be updated after this is merged. No third-party plugins will be impacted until 6.0 release. Before then, this will have to change one way or another anyway.
There was a problem hiding this comment.
Thanks. I will go ahead merging this into main in 2 hours.
In preparation of Instant Finality work,
block_header_statetoblock_header_state_legacy,block_header_state_ptrtoblock_header_state_legacy_ptr,block_statetoblock_state_legacy, andblock_state_ptrtoblock_state_legacy_ptr;block_header_state.{hpp,cpp}toblock_header_state_legacy.{hpp,cpp}, andblock_state.{hpp,cpp}toblock_state_legacy.{hpp,cpp};Resolved #1940