[5.0] Test: Fix trx_generator handling of connection lost #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I believe seeing the same problem in #1970 failures |
spoonincode
approved these changes
Dec 19, 2023
linh2931
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
on_exceptsonamed_thread_pooldoes not terminate when connection lost to client. This should fix the core dumps found in ci/cd runs such as #1865This is not a fix for #1865, as something caused nodeos to die for the
trx_generatorto lose connection and core dump. This PR however should remove the red herring of the trx_generator core files in ci/cd.