Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0 -> main] Report read-only API not enabled to caller #2151

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 29, 2024

Report read-only transactions execution not enabled on API node. Set read-only-threads > 0 to caller when /v1/chain/send_read_only_transaction is not supported because of no configured read-only-threads. Note this is handled correctly in 4.0.x.

Includes some misc fixes found while debugging this issue.

  • Log http errors before calling the callback cb, as cb may throw; e.g. cb not set.
  • Add missing } in a producer_plugin error log, so the error is reported correctly.
  • Add the response to the trx_provider error log when the http call fails.

Merges release/5.0 into main including #2148

@heifner heifner added the OCI Work exclusive to OCI team label Jan 29, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: INTERNALS
summary: Now report read-only API not enabled to caller, when read-only-threads is not configured.
Note: end

@arhag arhag merged commit 92967bb into main Jan 29, 2024
23 of 26 checks passed
@arhag arhag deleted the report-read-only-error-main branch January 29, 2024 19:05
@heifner heifner added this to the Leap v6.0.0-rc1 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants