Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0 -> main] More robust chain_api_plugin check in producer_plugin; take 2 #2157

Merged
merged 4 commits into from
Jan 29, 2024
Merged

[5.0 -> main] More robust chain_api_plugin check in producer_plugin; take 2 #2157

merged 4 commits into from
Jan 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 29, 2024

#2106 caused failure on hotstuff_integration branch as producer_plugin was initialized before chain_api_plugin. Search options instead of querying of appbase.

Merges release/5.0 into main including #2152

Resolves #2104

@heifner heifner added the OCI Work exclusive to OCI team label Jan 29, 2024
@heifner heifner merged commit e5d45ce into main Jan 29, 2024
26 checks passed
@heifner heifner deleted the GH-2104-find-chain_api_plugin-main branch January 29, 2024 20:40
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Additional enhancement to configuration parsing and check for chain_api_plugin, updated to search through options to be more resilient to changes in the timing of loading plugins.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read-only-threads is required to submit /v1/chain/send_read_only_transaction
4 participants
@heifner @ericpassmore @greg7mdp @linh2931