IF: Net plugin takes appropriate actions on invalid QC claims and invalid vote messages #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opping connection, keeping track, or ignoring)
greg7mdp
reviewed
Feb 1, 2024
| @@ -92,6 +92,14 @@ namespace eosio::chain { | |||
| invalid // invalid message (other reason) | |||
| }; | |||
|
|
|||
| enum class vote_status { | |||
| succeeded, | |||
There was a problem hiding this comment.
no big deal, but I think success is more typical as a status code than succeeded
greg7mdp
approved these changes
Feb 1, 2024
|
Note:start |
heifner
requested changes
Feb 2, 2024
…_off to closing_mode::handshake
heifner
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invalid QC claim or an invalid vote message is received, Net plugin needs to disconnect the peer immediately, keep track of the occurrence, or do nothing, based on the nature of validation failures. This PR classifies validation failures and implements the corresponding actions.
Resolved #1569.