Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Calculate IF Genesis Block finality digest correctly #2353

Merged
merged 6 commits into from
Mar 29, 2024
Merged

IF: Calculate IF Genesis Block finality digest correctly #2353

merged 6 commits into from
Mar 29, 2024
+35 −25

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 28, 2024

Resolves #2348

@heifner heifner added the OCI Work exclusive to OCI team label Mar 28, 2024
@heifner heifner requested review from greg7mdp and arhag March 28, 2024 16:48
@heifner heifner linked an issue Mar 28, 2024 that may be closed by this pull request
IF: Genesis block state finality digest correction #2348
Closed
@heifner
GH-2348 Make sure all attributes of block_state are populated in crea…
acc51cb 
…te_if_genesis_block. Avoid calculating strong_digest twice by providing it to new_valid().
@heifner heifner requested a review from greg7mdp March 28, 2024 20:05
Base automatically changed from GH-2334-bls-serialization to hotstuff_integration March 28, 2024 20:54
@heifner heifner requested a review from linh2931 March 28, 2024 20:56
linh2931
linh2931 requested changes Mar 29, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
greg7mdp
greg7mdp approved these changes Mar 29, 2024
View reviewed changes
libraries/chain/block_state.cpp Show resolved Hide resolved
libraries/chain/block_state.cpp Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Show resolved Hide resolved
@heifner heifner merged commit 5b83d32 into hotstuff_integration Mar 29, 2024
34 checks passed
@heifner heifner deleted the GH-2348-genesis-finality-digest branch March 29, 2024 21:55
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Correct the construction of finality digest when converting genesis block state.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

@arhag arhag Awaiting requested review from arhag

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Genesis block state finality digest correction
4 participants
@heifner @ericpassmore @greg7mdp @linh2931