Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: net: Add extra logging around async write #2355

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 29, 2024

Add additional debug logging around async write.
Make all logs that contain a connection id use a prefix of - so they are easy to grep for in the log.

debug 2024-03-28T20:58:09.489 net-2     net_plugin.cpp:2654           operator()           ] socket_is_open true, state connected, syncing false, connection - 4

The - matches default output of peer_* logging:

debug 2024-03-28T20:58:09.489 net-0     net_plugin.cpp:2668           operator()           ] ["localhost:9876 - b648e56" - 4 127.0.0.1:9876] bcast block 7

Should help verify issue of #2354 and #2351.

@heifner heifner added the OCI Work exclusive to OCI team label Mar 29, 2024
@heifner heifner merged commit 25b93a9 into hotstuff_integration Mar 29, 2024
33 of 34 checks passed
@heifner heifner deleted the net-plugin-logging branch March 29, 2024 15:30
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Add additional debug logging around async write. To make log grep easier, all logs with connection id now contain prefix of - .
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants