IF: SHiP -- Provide finality_data for Transition blocks #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Mar 29, 2024
heifner
requested changes
Mar 29, 2024
|
Note:start |
heifner
approved these changes
Apr 3, 2024
…earched for the Savanna Genesis Block
greg7mdp
requested changes
Apr 3, 2024
greg7mdp
reviewed
Apr 4, 2024
…ting temporary savanna block
greg7mdp
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of SHiP support of IBC was based on instant transition where Transition Savanna Blocks were not applicable. Now that proper Savanna transition has been implemented, @systemzax reports the
finality_datafor the second block after Savanna Genesis Block is not provided by SHiP. This PR addsfinality_datafor Transition blocks.#2360