Improve restart production integration test #552
Labels
enhancement
New feature or request
👍 lgtm
test-instability
tag issues for flaky tests, high priority to address
Milestone
The integration test introduced in #549 has a minor problem in that the test may not stop the node in the middle of a pending policy. If it misses it and the pending policy becomes active, then the test will still pass but it won't test the behavior the test was intended for.
The test can be improved as follows:
Instead of changing the order of the finalizer keys in order to force a finalizer policy change, change the finalizer policy to replace one of the keys (the one on the node to be shutdown). Then if the node to be shutdown does not have the new replacement key, we can guarantee that the pending policy will not become active. That guarantees that we can shut down the node in a state where it has a pending policy.
Then the shutdown node can be restarted with the new finalizer key also configured. This allows finality to advance, at least in the situation where the original bug was fixed.
The text was updated successfully, but these errors were encountered: