Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve restart production integration test #552

Closed
arhag opened this issue Aug 15, 2024 · 0 comments · Fixed by #577 or #658
Closed

Improve restart production integration test #552

arhag opened this issue Aug 15, 2024 · 0 comments · Fixed by #577 or #658
Assignees
Labels
enhancement New feature or request 👍 lgtm test-instability tag issues for flaky tests, high priority to address

Comments

@arhag
Copy link
Member

arhag commented Aug 15, 2024

The integration test introduced in #549 has a minor problem in that the test may not stop the node in the middle of a pending policy. If it misses it and the pending policy becomes active, then the test will still pass but it won't test the behavior the test was intended for.

The test can be improved as follows:

Instead of changing the order of the finalizer keys in order to force a finalizer policy change, change the finalizer policy to replace one of the keys (the one on the node to be shutdown). Then if the node to be shutdown does not have the new replacement key, we can guarantee that the pending policy will not become active. That guarantees that we can shut down the node in a state where it has a pending policy.

Then the shutdown node can be restarted with the new finalizer key also configured. This allows finality to advance, at least in the situation where the original bug was fixed.

@arhag arhag added this to the Spring v1.0.0-rc2 milestone Aug 15, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 15, 2024
@arhag arhag added enhancement New feature or request 👍 lgtm test-instability tag issues for flaky tests, high priority to address and removed triage labels Aug 15, 2024
@linh2931 linh2931 self-assigned this Aug 15, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Aug 15, 2024
@arhag arhag linked a pull request Aug 19, 2024 that will close this issue
@arhag arhag assigned greg7mdp and linh2931 and unassigned linh2931 and greg7mdp Aug 20, 2024
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Aug 27, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm test-instability tag issues for flaky tests, high priority to address
Projects
Archived in project
4 participants