[1.0] Improve restart production integration test #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
reviewed
Aug 18, 2024
|
Note:start |
heifner
requested changes
Aug 26, 2024
heifner
approved these changes
Aug 26, 2024
arhag
reviewed
Aug 27, 2024
arhag
approved these changes
Aug 27, 2024
ericpassmore
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing restart production test may not stop the node in the middle of a pending policy. If it misses it and the pending policy becomes active, then the test will still pass but it won't test the behavior the test was intended for.
Instead of changing the order of the finalizer keys in order to force a finalizer policy change, the test is changed to use an unconfigured key in the new finalizer policy such that it is guaranteed that the node is in a state where pending policy exists before the node is shut down.
Resolves #552