Do not post to thread pool while syncing/replaying #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Jun 11, 2024
| @@ -3978,18 +3980,20 @@ struct controller_impl { | |||
| // 3. Otherwise, consider voting for that block according to the decide_vote rules. | |||
|
|
|||
| if (!my_finalizers.empty() && bsp->core.final_on_strong_qc_block_num > 0) { | |||
| if (use_thread_pool == use_thread_pool_t::yes) { | |||
| boost::asio::post(thread_pool.get_executor(), [this, bsp=bsp]() { | |||
| if (bsp->is_recent() || my_finalizers.is_active()) { | |||
There was a problem hiding this comment.
A little annoying that we need || my_finalizers.is_active(), but I guess it is needed to ensure that once we start voting, we don't stop.
Maybe add a short comment to that effect as I don't think it is immediately obvious.
There was a problem hiding this comment.
Yeah, not really sure we need that restriction, but it is current requirements.
linh2931
approved these changes
Jun 11, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in review of #262,
address #262 (comment)