update to libsecp256k1 0.5.1 for small signing performance improvement #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Aug 6, 2024
| @@ -5,8 +5,7 @@ add_library(secp256k1-internal INTERFACE) | |||
| target_include_directories(secp256k1-internal INTERFACE secp256k1/src) | |||
|
|
|||
| target_compile_definitions(secp256k1-internal INTERFACE ENABLE_MODULE_RECOVERY=1 | |||
| ENABLE_MODULE_EXTRAKEYS=1 | |||
| COMB_BLOCKS=11 | |||
| COMB_BLOCKS=43 | |||
There was a problem hiding this comment.
These COMB settings come from
https://github.com/bitcoin-core/secp256k1/blob/3fdf146bad042a17f6b2f490ef8bd9d8e774cdbd/CMakeLists.txt#L93-L105
notice the default setting is now 86 and the COMB defines match what is here.
spoonincode
commented
Aug 6, 2024
| @@ -5,8 +5,7 @@ add_library(secp256k1-internal INTERFACE) | |||
| target_include_directories(secp256k1-internal INTERFACE secp256k1/src) | |||
|
|
|||
| target_compile_definitions(secp256k1-internal INTERFACE ENABLE_MODULE_RECOVERY=1 | |||
| ENABLE_MODULE_EXTRAKEYS=1 | |||
There was a problem hiding this comment.
EXTRAKEYS was added in #142 (comment) and as I suspected at that time, this was indeed a dependency oversight and has been fixed in 0.5.1.
heifner
approved these changes
Aug 6, 2024
linh2931
approved these changes
Aug 6, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump libsecp256k1 to v0.5.1.
v0.5.1 changes the default pre computed table size used for signing. The default was changed to match what Bitcoin Core is using (the highest configuration; i.e. largest table). So, change our configuration to match the new default. It seems entirely reasonable to use the same configuration Bitcoin Core does.
On a i7-12700K this improves signing time from about 17.4µs to 16.8µs on a gcc14 build. A 3% improvement at the cost of the secp256k1 context growing by 64KB (inconsequential growth).