[1.0] add BOOST_TEST_DEFAULTS_TO_CORE_DUMP
to libtester users
#626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOS VM within libtester needs to handle
SIGSEGV
. It's fine if other code using libtester chains their own SEGV handlers as well, but boost test by default completely takes overSIGSEGV
and this prevents proper operation of EOS VM within libtester.Previously inside of leap/spring we added
--catch_system_errors=no
to allctest
invocations of a boost unit test. This works but is a bit annoying because when running the test manually you need to also remember to manually pass--catch_system_errors=no
or can experience problems. So instead AntelopeIO/leap#1849 does this globally by settingBOOST_TEST_DEFAULTS_TO_CORE_DUMP
But that doesn't change behavior for users of libtester and their native contract unit tests. They still would need to know to pass
--catch_system_errors=no
to get proper behavior from libtester and EOS VM. Oftentimes this doesn't matter because generally users of libtester aren't banging on wasm memory faults, but EOS EVM's tests did stumble on this problem recently. So let's addBOOST_TEST_DEFAULTS_TO_CORE_DUMP
to any users of libtester so they do not need to know to--catch_system_errors=no
.Sending to 1.0 because of EOS EVM struggles here.