Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Add testcase validating the new fsi design from issue #621. #636

Merged
merged 25 commits into from
Aug 28, 2024
Merged

[1.0] Add testcase validating the new fsi design from issue #621. #636

merged 25 commits into from
Aug 28, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Aug 26, 2024 •
edited
Loading

Partially resolves #621.

Adds a testcase that demonstrates issue #621. Testcase fails prior to PR #627, but runs successfully with the changes from PR #627.

@greg7mdp greg7mdp changed the base branch from release/1.0 to gh_544 August 26, 2024 14:48
heifner
heifner requested changes Aug 26, 2024
View reviewed changes
libraries/testing/tester.cpp Outdated Show resolved Hide resolved
unittests/savanna_misc_tests.cpp Outdated Show resolved Hide resolved
@heifner heifner changed the title Add testcase validating the new fsi design from issue #621. [1.0] Add testcase validating the new fsi design from issue #621. Aug 26, 2024
@heifner heifner linked an issue Aug 26, 2024 that may be closed by this pull request
Update fsi and decide_vote to solve weak masking issue without regression in liveness #621
Closed
Base automatically changed from gh_544 to release/1.0 August 26, 2024 18:01
arhag
arhag reviewed Aug 27, 2024
View reviewed changes
unittests/savanna_misc_tests.cpp Outdated Show resolved Hide resolved
unittests/savanna_misc_tests.cpp Outdated Show resolved Hide resolved
@greg7mdp
Copy link
Contributor Author

@arhag , issue #621 mentions:
"In addition to checking that the blocks have the claims as required above and the LIB as noted below, the test should also check that the fsi record after each vote is as expected below"

I'm still planning to add checks for the fsi data this morning.

@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Test to validate new, generation 1, finalizer safety information.
Note:end

@heifner heifner mentioned this pull request Aug 27, 2024
Merged
@greg7mdp greg7mdp merged commit b4fbc56 into release/1.0 Aug 28, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_621 branch August 28, 2024 00:18
@ericpassmore ericpassmore added the bug The product is not working as was intended. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@heifner heifner heifner approved these changes

@linh2931 linh2931 Awaiting requested review from linh2931

Assignees
No one assigned
Labels
bug The product is not working as was intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fsi and decide_vote to solve weak masking issue without regression in liveness
4 participants
@greg7mdp @ericpassmore @heifner @arhag