Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Media kit & Branding page #236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Media kit & Branding page #236

wants to merge 3 commits into from

Conversation

keunes
Copy link
Member

@keunes keunes commented May 8, 2023

And publish the first press release.

Note: This PR doesn't (yet) update the GH actions required for translations. A separate PR will be required.

* Remove deprecated strings from translation files
* Update Actions
@keunes
Copy link
Member Author

keunes commented May 10, 2023

GH build fails - as does Netlify. Both have the same issue:

Building site for language: "en" to: /home/runner/work/antennapod.github.io/antennapod.github.io/_site
Loading translation from file /home/runner/work/antennapod.github.io/antennapod.github.io/_i18n/en.yml
Missing i18n key: en:<p class="lead">Tuesday 9 May 2023 – The new 3.0 release of the free and ad-free podcast app for Android ‘AntennaPod’ introduces a Home screen, giving users an overview of the most important sections and content in the app. This new version will land in users’ hands with a refreshed icon and interface. The updated app is available for download on Google Play and F-Droid from today.</p>
  Liquid Exception: no implicit conversion of nil into String in /home/runner/work/antennapod.github.io/antennapod.github.io/_layouts/internal.html
                    ------------------------------------------------
      Jekyll 4.3.1   Please append `--trace` to the `build` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------

I don't really understand, though. There are no translations for the whole file - _i18n/en/press-releases/2023-05-08-version-3.md exists only in English. That's not an issue for other files without translation. Maybe the {: .lead} tag is throwing something off?

@ByteHamster
Copy link
Member

Sounds like something is trying to translate the already translated blog post title again. I don't know what .lead does.

@keunes
Copy link
Member Author

keunes commented May 13, 2023

I don't know what .lead does.

It applies the (lead) class to the element (paragraph) that follows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants