Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Tree traversal techniques inorder, preorder and postorder in c++ lang #172

Merged
merged 3 commits into from Oct 14, 2020
Merged

added Tree traversal techniques inorder, preorder and postorder in c++ lang #172

merged 3 commits into from Oct 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2020

PR for issue #101
All traversals are based on recursion.

@Anuja-19 Anuja-19 merged commit 27572ed into Anuja-19:main Oct 14, 2020
@ghost
Copy link
Author

ghost commented Oct 23, 2020

Could you please tell me how long it would take to get hacktoberfest-accepted label??
Is the pr not elligible for that?
Thanks

@Anuja-19
Copy link
Owner

@abhstract
I have already merged the PR. It is not necessary to put a label on it. Your review period must have started 9 days ago. Please check once.

@ghost
Copy link
Author

ghost commented Oct 23, 2020

@Anuja-19
Ok but one more thing that I noticed is I am unable to find my contribution in the folders. Actually being new to github I expected to see my it. Is this somehow related to hacktoberfest?? or have I done some mistake while deleting the file during pull request??
Thanks

@Anuja-19
Copy link
Owner

Anuja-19 commented Oct 23, 2020

I see that you have added an empty file to cpp folder.. You need to edit the file with valid code.

@ghost
Copy link
Author

ghost commented Oct 23, 2020

So basically what I am asking is in case of mutiple pr's The first pr would contain a single change whereas the second one would contain both the changes right?? because I found my second file having 3 changes do I deleted the previous change.

@ghost ghost deleted the newb branch October 23, 2020 06:54
@Anuja-19
Copy link
Owner

When you create a PR and do the changes twice, it means you have one pr with multiple commits. So it is only one PR with multiple changes that you do not need to delete.
Now it just shows an empty file, please see if you can edit the file and add code in that empty file.

@ghost
Copy link
Author

ghost commented Oct 25, 2020

@Anuja-19 Please review my pull request at the earliest.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants