Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need alias property for accounts #11

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Conversation

johnson2427
Copy link
Collaborator

@johnson2427 johnson2427 commented Jun 21, 2024

What I did

fixes: #10

How I did it

Added alias property to `KmsAccount

How to verify it

$ ape accounts list --all
Found 4 accounts in the 'aws' plugin:
  0xFC28b8BBf5Dc0D85804a21c5C5412fD1BAd39b5C (alias: 'EthKMSKey')
  0xa11F0200c0F4292B44501051Fc1B3B13dda8c010 (alias: 'KeyAlias')
  0x532B0Fd2569494e6c2c7429B50ea949bF2a0B9cA (alias: 'importedTestKey')
  0xE1eFB6289EF575CeBa78115502894E099Ec3FD20 (alias: 'testingKey')

Found 4 accounts in the 'accounts' plugin:
  0x8082513C5794917c91F8dAcc2303Ed65e0B0bD65 (alias: 'ape_test')
  0x47c93237A35510D91b85f01454F82Af7f620bD6c (alias: 'main')
  0x47c93237A35510D91b85f01454F82Af7f620bD6c (alias: 'acc0')
  0x6ed7A062D364771cD4e3BAe42E46E32752f296A8 (alias: 'acc1')

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ape_aws/accounts.py Outdated Show resolved Hide resolved
@johnson2427 johnson2427 merged commit b367ec6 into main Jun 21, 2024
18 of 19 checks passed
@johnson2427 johnson2427 deleted the fix/add-alias-to-kmsaccount branch June 21, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing alias property to KmsAccount
2 participants