-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade dockerfile to python 3.10 [APE-1112] #1495
feat!: upgrade dockerfile to python 3.10 [APE-1112] #1495
Conversation
Is this a breaking change for the image? Wondering if this should happen in 0.7 versus now. Note, you can set PYTHON_ARG="3.10" in silverback if you need to |
this can wait for a later version if this is a breaking change, but it doesn't seem to break anything for me?
|
I agree with @antazoey, this could be a breaking change, and there's a workaround for now |
@antazoey should I close this or leave it open? |
I think we should migrate everything that only used 3.8 to 3.10 when we migrate things for the v0.7.0 release (such as linting CI, base image, etc.) |
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
I think this is now a blocker for chaosnet ApePay integration. I tried using |
Noting that this is breaking change for some, but hopefully impact is small |
What I did
upgrade dockerfile to python 3.10 by using python 3.10 slim base image
How I did it
wanted to have python 3.10 as base image so that using python 3.10
How to verify it
docker build -t ape .
docker run -it --entrypoint /bin/bash ape
Checklist