-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: project system refactors #1960
Conversation
acd34ba
to
3da1910
Compare
27f76a0
to
8b8be57
Compare
So right now on this PR, the notion of the separated My idea is to output ABIs to a subfolder in .build, maybe if and only if you configure Ape to do so, and the source of truth remains in the manifest, and the ABIs just get places (and replaced) upon ever compilation via looking at all types in the manifest after compilation finishes. This way, users can still host these files and they are even smaller and they are unrelated to the rest of Ape... but am open to other ideas or even just putting back as-is. And by making it config driven, it becomes opt-in and most centered to the idea of minimization. |
764152e
to
8b56ea4
Compare
b55e936
to
50e4670
Compare
dc88821
to
48cbf01
Compare
adcf956
to
ef9b1fa
Compare
e2f01b8
to
cacf1e7
Compare
cacf1e7
to
fe2a1d9
Compare
:caption: Plugin Python Reference | ||
:maxdepth: 1 | ||
|
||
methoddocs/ape_accounts.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtdang See how I am taking ape-accounts
out of above and making a new section here for Plugin Python Reference
? I want us to try and do this for core right now with all the core plugins. I had to make some changes in the core plugins to get it to work though, had to add __all__
= in the init, also some other docs files for the auto-modding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I did
fixes: #1113
fixes: #660
required this PR: ApeWorX/ape-solidity#134
ape-vyper needs the same but havent done yet.
btw, just about everything is probably broken still, but i got all project system kinda working, so opening so no one think i just ghosted, because this has been a lot of refactoring
How I did it
How to verify it
Checklist