refactor!: make data_folder a property instead of a field in network-APIs
#2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
approved these changes
Apr 29, 2024
antazoey
force-pushed
the
refactor/network-data-folder
branch
from
7215d59
to
7581391
Compare
antazoey
added a commit
that referenced
this pull request
May 1, 2024
antazoey
added a commit
that referenced
this pull request
May 1, 2024
antazoey
added a commit
that referenced
this pull request
May 3, 2024
antazoey
added a commit
that referenced
this pull request
May 6, 2024
NotPeopling2day
pushed a commit
to antazoey/ape
that referenced
this pull request
May 7, 2024
antazoey
added a commit
that referenced
this pull request
May 7, 2024
antazoey
added a commit
that referenced
this pull request
May 8, 2024
antazoey
added a commit
that referenced
this pull request
May 9, 2024
antazoey
added a commit
that referenced
this pull request
May 9, 2024
antazoey
added a commit
that referenced
this pull request
May 9, 2024
antazoey
added a commit
to antazoey/ape
that referenced
this pull request
May 9, 2024
antazoey
added a commit
that referenced
this pull request
May 14, 2024
antazoey
added a commit
that referenced
this pull request
May 14, 2024
antazoey
added a commit
that referenced
this pull request
May 21, 2024
antazoey
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
data_folder being a field is not needed.
every plugin we have uses the name in the
.apedata folder - so this simplifies things a lotplugins can still override the data folder if needed.
also fields are special in pydantic so this is less complicated in that regard.
all part of the efforts of making the project refactor smaller btw.
this pr also contains all of https://github.com/ApeWorX/ape/pull/2037/files which is targeting main but itll get rebased out
How I did it
How to verify it
Checklist