Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where could not have dependencies with contracts_folder pointed at the root project path #2048

Merged
merged 2 commits into from
May 3, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented May 2, 2024

What I did

fixed a bug where could not compile dependencies like:

dependencies:
  - name: b64
    github: Brechtpd/base64
    ref: main
    contracts_folder: .

issue: it got turned to "" via a bad replace during a config manifestation.

How I did it

if the paths re equal, make the temp config value for contracts_folder be "."

NOTE: This all makes so much more sense on the project refactor for 0.8 .... just sayin! But this is a solid fix for the 0.7 range I think.

ALSO: I purposely made the test an integration test to ensure this carries over to 0.8 because any functional test would likely get erased (so I didn't add any of those).

How to verify it

Use this config:

dependencies:
  - name: b64
    github: Brechtpd/base64
    ref: main
    contracts_folder: .

and run:

ape pm install .

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu previously approved these changes May 2, 2024
@antazoey antazoey force-pushed the fix/compile-empty-project branch from 1650748 to fc3308e Compare May 3, 2024 13:51
@antazoey antazoey merged commit df95b4e into ApeWorX:main May 3, 2024
17 checks passed
@antazoey antazoey deleted the fix/compile-empty-project branch May 3, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants