Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow convert(0, AddressType) to work #2066

Merged
merged 3 commits into from
May 7, 2024
Merged

feat: allow convert(0, AddressType) to work #2066

merged 3 commits into from
May 7, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented May 7, 2024

What I did

Create simple addresses a lot easier by allowing:

In [1]: from ape.types import AddressType

In [2]: convert(0, AddressType)
Out[2]: '0x0000000000000000000000000000000000000000'

How I did it

Use eth_pydantic_types validator

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey merged commit 176dc2a into ApeWorX:main May 7, 2024
17 checks passed
@antazoey antazoey deleted the perf/hexconverter branch May 7, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu