fix: trace API fixes #2093
Merged
fix: trace API fixes #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
antazoey
force-pushed
the
fix/more-trace-fixes
branch
from
9f9e8c7
to
f54fa4d
Compare
fubuloubu
approved these changes
May 16, 2024
antazoey
added a commit
that referenced
this pull request
May 21, 2024
antazoey
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As I was working on
ape-foundryfeat/08 support, some things have come up with theTraceAPIrefactor:fix: during trace enrichment, handle if the returnvalue is a custom revert message
fix: make
stream_requestavailable to all Web3Provider (switch base-class it is defined in)fix: in
Trace.revert_message, handle the first fix but checking if revert message already present in enriched call, use that if that is the casefix: issues where custom errors werent working great
fix: issue where gas was not added to top levels calls when using structLogs approach for call trees
How I did it
How to verify it
Tests are coming for core, but with these changes,
ape-foundryis able to pass its full test suiteChecklist