fix: issue where plugin config loading error was not shown #2150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I had my config set up with some environment variables that did not exist, and i noticed that instead of Ape crashing where it was supposed to, my error s were dropped and the configs were turned to regular
PluginConfig
and i got attribute errors within the plugin instead, kinda weird...How I did it
Removed duplicate
get_config
method that hid the errors for no reason.instead, let
ConfigManager
runApeConfig.get_config
and the error shows up correctly.How to verify it
try to use foundry
Checklist