fix: ContractName import issue on eth-typing==5.0.0
#2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
ContractName issue on eth-typingContractName import issue on eth-typing==5.0.0
|
as an aside, hoping when this merges to main, the latest/ docs build is fixed... |
fubuloubu
previously approved these changes
Oct 15, 2024
antazoey
commented
Oct 15, 2024
| @@ -203,7 +203,7 @@ def test_uncaught_txn_err(setup_pytester, integ_project, pytester, eth_tester_pr | |||
| def test_show_internal(setup_pytester, integ_project, pytester, eth_tester_provider): | |||
| _ = eth_tester_provider # Ensure using EthTester for this test. | |||
| setup_pytester(integ_project) | |||
| result = pytester.runpytest_subprocess("--show-internal") | |||
| result = pytester.runpytest_subprocess("-p", "no:pytest_ethereum", "--show-internal") | |||
There was a problem hiding this comment.
@fubuloubu this is the annoying part, have to make sure pytest_ethereum is disabled :(
thinking
i tried disabling in the plugin but the problem happens earlier than the loading of our plugin. pytest_ethereum loads up and fails before ape's pytest plugin does.
bitwise-constructs
approved these changes
Oct 15, 2024
fubuloubu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I believe the fix is just to bump to 5.0.1 so you can't use 5.0.0
How I did it
How to verify it
Checklist