-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lookup network in evmchains; plugin-less networks, adhoc networks w/ correct name #2328
Conversation
2c52d42
to
bf8e066
Compare
a244818
to
8de8d6c
Compare
Failing test only happens on Web3>=6.20.2 not on 6.20.1 (which is what i was using locally) |
ac8da35
to
b8d96cd
Compare
:< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this could do with a little extra testing from @bitwise-constructs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I confirmed that custom network names still take precedence over names in evmchains
Although I was digging more into the custom network names and I'm not clear on how that works. If I set up one in my yaml like this
and then call
but if I change the call to
|
@bitwise-constructs Networks are the middle value in To use your custom network shibarium:scroll, you would do note: scroll is not a network on shibarium so youd be a bit hacky here, also because of that you would have to configure a URI for it |
ea5cba1
de8e036
to
ea5cba1
Compare
What I did
How I did it
Use
evmchains
library.How to verify it
First, I have no plugin for moonbeam installed, but yet i can do this:
and it "just works"
Second, if I connect to a URL in the same fashion:
ape console --network "https://moonriver.unitedbloc.com"
Not only does it work (did before), but the network name and stuff is correct:
taa daaaa
Checklist