fix: recursion error when a bad URI was configured in node:
#2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I put in a very non-URI value in my config to demo something and it blew up not how i expected.
This PR fixes it.
How I did it
Noticed a comment was wrong, that was where to fix.
Basically make it error if given a value that is neither HTTP, WS, or IPC.
How to verify it
Before, it would recurse until it failed.
Now, you get:
Checklist