Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursion error when a bad URI was configured in node: #2372

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 4, 2024

What I did

I put in a very non-URI value in my config to demo something and it blew up not how i expected.
This PR fixes it.

How I did it

Noticed a comment was wrong, that was where to fix.
Basically make it error if given a value that is neither HTTP, WS, or IPC.

How to verify it

node:
  ethereum:
    mainnet:
      uri: asdfasdf
ape console --network ethereum:mainnet:node

Before, it would recurse until it failed.
Now, you get:

ERROR:    (ConfigError) Invalid URI (not HTTP, WS, or IPC): asdfasdf

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey enabled auto-merge (squash) November 4, 2024 16:53
@antazoey antazoey merged commit 6a8a737 into ApeWorX:main Nov 4, 2024
16 checks passed
@antazoey antazoey deleted the fix/bad-uri-recursion-error branch November 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants