refactor: use manifest project #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Sep 19, 2024
|
I verified the tests still pass |
fubuloubu
reviewed
Sep 19, 2024
Co-authored-by: El De-dog-lo <[email protected]>
antazoey
commented
Sep 19, 2024
| @@ -178,19 +178,11 @@ async def compile_project(project_root: Path, manifest: PackageManifest): | |||
| # Create a contracts directory | |||
| contracts_dir = project_root / "contracts" | |||
| contracts_dir.mkdir() | |||
| project = Project.from_manifest(manifest) | |||
There was a problem hiding this comment.
btw when it comes time to add the dependencies, you can do it like this:
project = Project.from_manifest(manifest, config_override={"dependencies": [{"pypi": "snekmate"}]})
There was a problem hiding this comment.
can config_override accept a list of DependencyAPI objects? that's how I was thinking to parse the incoming dependency specifications
There was a problem hiding this comment.
i think you can pass in objects as well but you dont have to: itll validate them if you use raw dicts
fubuloubu
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This code is a good candidate for Ape's 0.8's manifest-based project
How I did it
How to verify it
run:
then run
not sure why i cant get tests to run
Checklist