Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate use of stdin with 0.4.x compiler #87

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Always include - to indicate use of stdin. This wasn't a requirement for compiling until 0.5.0, but it turns out it was always needed when combined with import_remappings.

Fixes #85

How I did it

In wrapper.py, remove the check for and solc_minor >= 5 when deciding if - should be added.

How to verify it

Run the tests. I've added a new case to verify the behavior of import_remappings when combined with compile_source.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 1c3f1f3 into master Jul 16, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-import-remappings branch July 16, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for solc path mappings
1 participant