Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of BACKWARD_TRANSITIVE, FORWARD_TRANSITIVE might be incorrect #1239

Closed
blacktooth opened this issue Feb 19, 2021 · 4 comments
Closed

Implementation of BACKWARD_TRANSITIVE, FORWARD_TRANSITIVE might be incorrect #1239

blacktooth opened this issue Feb 19, 2021 · 4 comments
Labels
type/question Further information is requested

Comments

@blacktooth
Copy link
Contributor

blacktooth commented Feb 19, 2021 •
edited
Loading

My understanding of transitive compatibility modes (BACKWARD_TRANSITIVE, FORWARD_TRANSITIVE) is that schema registry ensures that the updated schema version is compatible with all the versions in the registry.

However, the code in JsonSchemaCompatibilityChecker checks compatibility between old versions.

Current behavior:

isCompatible(latest, latest-1) && isCompatible(latest - 1, latest - 2) && isCompatible(latest - 2, latest - 3) ...

Expected behavior:

isCompatible(latest, latest-1) && isCompatible(latest , latest - 2) && isCompatible(latest, latest - 3) ...

Is my understanding correct?
@EricWittmann EricWittmann added the type/question Further information is requested label Feb 22, 2021
@EricWittmann
Copy link
Member

Thoughts @jsenko ?

@jsenko
Copy link
Member

jsenko commented Feb 24, 2021

The standard definition of transitivity is A <c B and B <c C implies A <c C. You are right, we are checking the left side but not the right side.

@jsenko
Copy link
Member

jsenko commented Feb 24, 2021

I found other issues in the current master, I'm working on a PR.

@EricWittmann
Copy link
Member

I recommend you do any work against the feat/artifact-groups branch.

jsenko added a commit to jsenko/apicurio-registry that referenced this issue Feb 24, 2021
@jsenko
Incorrect transitive compatibility checking for JSON schemas. Fixes A…
55bb747 
…picurio#1239
@jsenko jsenko mentioned this issue Feb 24, 2021
Merged
EricWittmann pushed a commit that referenced this issue Feb 24, 2021
@jsenko
Incorrect transitive compatibility checking for JSON schemas. Fixes #…
a9bff9b 
…1239 (#1257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blacktooth @jsenko @EricWittmann