Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth documentation #1133

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Conversation

carlesarnal
Copy link
Member

No description provided.

@carlesarnal carlesarnal linked an issue Jan 13, 2021 that may be closed by this pull request
@EricWittmann
Copy link
Member

Waiting on review by @smccarthy-ie before merging this.

@@ -45,3 +45,6 @@ endif::[]
* Compatibility with existing Confluent schema registry client applications

* Operator-based installation of {registry} on OpenShift

* Support for oidc based authentication

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest spelling out the acronym:
"Support for OpenID Connect (OIDC) authentication"

[id="registry-security"]

= Configuring {registry} with Authentication

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest lowercase "authentication" for consistency with sentence style headings

This section explains how to configure authentication and authorization for {registry}. In order to configure the authentication the following environment variables should be used:

.Environment variables for {registry} authentication configuration.
//[%header,cols="5,5,2,5"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest removing full stop from heading

|String
|`false`
|`KEYCLOAK_URL`
|The url of the auth server to be used. Must end with `/auth.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: Must end with /auth (add closing backtick)



.Environment variables for {registry} authentication configuration.
//[%header,cols="5,5,2,5"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest heading such as:
Default user roles for {registry} authentication

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste mistake, sorry.

|String
|
|`KEYCLOAK_API_CLIENT_ID`
|The client id for the rest API.
Copy link
Contributor

@smccarthy-ie smccarthy-ie Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "The client ID for the {registry} REST API."

= Configuring {registry} with Authentication

This section explains how to configure authentication and authorization for {registry}. In order to configure the authentication the following environment variables should be used:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "This section explains how to configure authentication and authorization for {registry} based on OpenID Connect (OIDC)."

|`KEYCLOAK_UI_CLIENT_ID`
|The client id to be used by the user interface
|String
|`apicurio-registry`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "The client ID for the {registry} user interface"

@EricWittmann
Copy link
Member

@carlesarnal All set on this?

@carlesarnal
Copy link
Member Author

@carlesarnal All set on this?

Yes, @smccarthy-ie comments addressed.

@EricWittmann EricWittmann merged commit f48f196 into Apicurio:master Jan 15, 2021
@carlesarnal carlesarnal deleted the auth-documentation branch January 18, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the new AuthN/Z options
3 participants