-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth documentation #1133
Add auth documentation #1133
Conversation
Waiting on review by @smccarthy-ie before merging this. |
@@ -45,3 +45,6 @@ endif::[] | |||
* Compatibility with existing Confluent schema registry client applications | |||
|
|||
* Operator-based installation of {registry} on OpenShift | |||
|
|||
* Support for oidc based authentication | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest spelling out the acronym:
"Support for OpenID Connect (OIDC) authentication"
[id="registry-security"] | ||
|
||
= Configuring {registry} with Authentication | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest lowercase "authentication" for consistency with sentence style headings
This section explains how to configure authentication and authorization for {registry}. In order to configure the authentication the following environment variables should be used: | ||
|
||
.Environment variables for {registry} authentication configuration. | ||
//[%header,cols="5,5,2,5"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest removing full stop from heading
|String | ||
|`false` | ||
|`KEYCLOAK_URL` | ||
|The url of the auth server to be used. Must end with `/auth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: Must end with /auth
(add closing backtick)
|
||
|
||
.Environment variables for {registry} authentication configuration. | ||
//[%header,cols="5,5,2,5"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest heading such as:
Default user roles for {registry} authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-paste mistake, sorry.
|String | ||
| | ||
|`KEYCLOAK_API_CLIENT_ID` | ||
|The client id for the rest API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest "The client ID for the {registry} REST API."
= Configuring {registry} with Authentication | ||
|
||
This section explains how to configure authentication and authorization for {registry}. In order to configure the authentication the following environment variables should be used: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest "This section explains how to configure authentication and authorization for {registry} based on OpenID Connect (OIDC)."
|`KEYCLOAK_UI_CLIENT_ID` | ||
|The client id to be used by the user interface | ||
|String | ||
|`apicurio-registry` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest "The client ID for the {registry} user interface"
@carlesarnal All set on this? |
Yes, @smccarthy-ie comments addressed. |
No description provided.