Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the UI based on UX designs. #1795

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Updates to the UI based on UX designs. #1795

merged 2 commits into from
Sep 3, 2021

Conversation

EricWittmann
Copy link
Member

No description provided.

jsenko
jsenko reviewed Aug 30, 2021
View reviewed changes
Copy link
Member

@jsenko jsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are test failures

@jsenko jsenko self-requested a review August 30, 2021 13:31
jsenko
jsenko approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@jsenko jsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@famarting
Copy link
Contributor

@EricWittmann tests should pass now

@EricWittmann
Copy link
Member Author

Looks like almost! :)

image

@EricWittmann
Copy link
Member Author

I'm going to merge anyway, and we can work out the test problem (if there is one) later.

@EricWittmann EricWittmann merged commit 0fe2ad9 into Apicurio:master Sep 3, 2021
@EricWittmann EricWittmann deleted the feat/ui-updates-from-ux branch September 3, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsenko jsenko jsenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricWittmann @famarting @jsenko