Add artifact created event based on the outbox pattern #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlesarnal
force-pushed
the
implement-registry-event-source
branch
2 times, most recently
from
5d4261b
to
623ad42
Compare
carlesarnal
force-pushed
the
implement-registry-event-source
branch
from
623ad42
to
128e13b
Compare
carlesarnal
force-pushed
the
implement-registry-event-source
branch
from
dc83838
to
b2aa62c
Compare
carlesarnal
force-pushed
the
implement-registry-event-source
branch
from
2e0695f
to
835676a
Compare
EricWittmann
reviewed
Oct 4, 2024
app/src/main/java/io/apicurio/registry/storage/impl/kafkasql/KafkaSqlFactory.java
Outdated
Show resolved
Hide resolved
EricWittmann
reviewed
Oct 4, 2024
app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java
Outdated
Show resolved
Hide resolved
EricWittmann
requested changes
Oct 4, 2024
carlesarnal
force-pushed
the
implement-registry-event-source
branch
from
94a179d
to
e95d66e
Compare
carlesarnal
force-pushed
the
implement-registry-event-source
branch
from
afb1b36
to
1b7869e
Compare
carlesarnal
force-pushed
the
implement-registry-event-source
branch
from
1b7869e
to
dfe2dc9
Compare
EricWittmann
approved these changes
Oct 9, 2024
Good question. If the Kafka cluster is there anyway, what would be the reason to not use Debezium? In the end, what we're doing is very basic CDC, so I don't see any benefits other than simplifying (a bit) the deployment model. For now, I'll merge as-is, we can revisit later if we think it makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for having Registry as a source for events. In the case of the SQL storage, an outbox table has been added and a row is created for each of the following events:
Note that the event sending is done at the storage impl level on purpose, so we have access to the underlying transaction so we can benefit from the usual advantages of the outbox pattern in the SQL storage. We don't have now a way to intercept the transaction, so this was the only possible way.