Skip to content

Commit

Permalink
Re-enable failing tests (#2255)
Browse files Browse the repository at this point in the history
Disable TFM parallelism for `dotnet test` in the Polly.Core project on Windows to fix two failing tests.
See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
  • Loading branch information
martincostello committed Aug 17, 2024
1 parent 781123c commit 6d4f7e2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public async Task Dispose_ScheduledTaskCancelled()
.Throw<ObjectDisposedException>();
}

[Fact(Skip = "TODO - Failing under .NET Framework for some reason.")]
[Fact]
public void Dispose_WhenScheduledTaskExecuting()
{
using var disposed = new ManualResetEvent(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Polly.Core.Tests.Issues;

public partial class IssuesTests
{
[Fact(Timeout = 15_000, Skip = "TODO - Failing under .NET 9 for some reason.")]
[Fact(Timeout = 15_000)]
public async Task InfiniteRetry_Delay_Does_Not_Overflow_2163()
{
// Arrange
Expand Down
1 change: 1 addition & 0 deletions test/Polly.Core.Tests/Polly.Core.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<TargetFrameworks>net9.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">$(TargetFrameworks);net481</TargetFrameworks>
<TestTfmsInParallel Condition="$([MSBuild]::IsOSPlatform('Windows'))">false</TestTfmsInParallel>
<ProjectType>Test</ProjectType>
<Nullable>enable</Nullable>
<Threshold>100</Threshold>
Expand Down

0 comments on commit 6d4f7e2

Please sign in to comment.