Fix package validation #2138
Merged
Fix package validation #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
martincostello
commented
May 29, 2024
•
martincostello
commented
- Fix the package validation job not failing if there are any issues.
- Fix package validation issues caused by Update .NET SDK to 8.0.300 #2110.
Fix the package validation job not failing if there are any issues.
Move configuration of deterministic builds to MSBuild, rather than setting it from Cake, as this appears to have stopped working with the .NET 8.0.300 SDK.
Use `exit` not `return`.
|
Interestingly the attempt at fixing the 3 packages makes it worse as all 5 packages are now not marked as deterministic... |
Fix missing exit in other validation step.
Try moving the property declarations into `Directory.Build.props`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.