Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appimagetool usage in docker #546

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

cajomar
Copy link
Contributor

@cajomar cajomar commented Oct 14, 2023

Invocation from docker was failing because the generate_type2_appimage function was attempting to operate on a local path appimagetool instead of expanding the $appimagetool variable, giving this error:

mv: cannot stat 'appimagetool': No such file or directory

Adding this line to my script fixed my job:

sed -i -e 's/mv appimagetool/mv $appimagetool/' /opt/pkg2appimage.AppDir/usr/share/pkg2appimage/functions.sh

Full CI script: https://gitlab.com/cajomar/snowballz/-/blob/59fc8c35168a007a064e63885425a47278bbb989/.gitlab-ci.yml

@probonopd
Copy link
Member

Thanks @cajomar, looks reasonable.

@probonopd probonopd merged commit a15be9d into AppImageCommunity:master Oct 28, 2023
1 check passed
@cajomar cajomar deleted the fixdocker branch October 28, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants