-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recompile index.js and upgrade actions/core to fix all errors/warnings #41
Conversation
Any reason why this hasn't been merged yet? |
I'm trying your fork/PR and the errors are gone. Looks like the certs imported properly as well. |
@orj are you managing these pr's or does this repo need a new maintainer? |
@ssrobins Thanks for the offer. I've added you to the org. |
Thanks @orj! I guess the next step would be to make a |
Ah. I'll probably have to tweak the repo permissions. I'll have to do that when I get in to work tomorrow. |
@orj any updates on this? |
You should have write permissions. |
Thanks, it works. |
This work fixes the following issues:
#28
#29
#40
To fix the runtime error in GitHub Actions, I ran the commands in the contributing doc. Then, following the steps in this tutorial, ran the following to update index.js:
ncc build src/main.ts --license licenses.txt
I followed the recommendations in this blog to upgrade
@actions/core
tov1.10.0
, which got rid of the runtime warning in GitHub Actions.