Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompile index.js and upgrade actions/core to fix all errors/warnings #41

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

ssrobins
Copy link
Contributor

@ssrobins ssrobins commented Nov 6, 2022

This work fixes the following issues:
#28
#29
#40

To fix the runtime error in GitHub Actions, I ran the commands in the contributing doc. Then, following the steps in this tutorial, ran the following to update index.js:
ncc build src/main.ts --license licenses.txt

I followed the recommendations in this blog to upgrade @actions/core to v1.10.0, which got rid of the runtime warning in GitHub Actions.

@rcdailey
Copy link

Any reason why this hasn't been merged yet?

@erikng
Copy link

erikng commented Dec 29, 2022

I'm trying your fork/PR and the errors are gone. Looks like the certs imported properly as well.

@steveoh
Copy link

steveoh commented Feb 1, 2023

@orj are you managing these pr's or does this repo need a new maintainer?

@ssrobins
Copy link
Contributor Author

ssrobins commented Feb 2, 2023

@orj are you managing these pr's or does this repo need a new maintainer?

@orj feel free to assign the repo to me, if you like. Grateful you set it up in the first place, but it doesn't mean you have to maintain it forever. It takes a village and all that :)

@orj
Copy link
Contributor

orj commented Feb 20, 2023

@ssrobins Thanks for the offer. I've added you to the org.

@orj orj merged commit 8f3fb60 into Apple-Actions:master Feb 20, 2023
@ssrobins ssrobins deleted the v2 branch February 23, 2023 01:44
@ssrobins ssrobins restored the v2 branch February 23, 2023 01:59
@ssrobins
Copy link
Contributor Author

Thanks @orj! I guess the next step would be to make a v2 tag from latest master and push it, do you agree? I don't have access to do that, though.

@orj
Copy link
Contributor

orj commented Feb 23, 2023

Ah. I'll probably have to tweak the repo permissions. I'll have to do that when I get in to work tomorrow.

@ssrobins
Copy link
Contributor Author

@orj any updates on this?

@orj
Copy link
Contributor

orj commented Mar 11, 2023

@orj any updates on this?

You should have write permissions.

@ssrobins
Copy link
Contributor Author

@orj any updates on this?

You should have write permissions.

Thanks, it works. v2 tag is now pushed and apple-actions/import-codesign-certs@v2 action now works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants