update: Enhanced Error Handling for License Server API Calls #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurul-umbhiya
changed the title
|
@Rubaiyat-E-Mohammad Need to test this |
Rubaiyat-E-Mohammad
added
the
QA: In Progress
|
Updated and replaced the license.php file and executed the scenario. video: Link |
Rubaiyat-E-Mohammad
added
the
Needs Dev Review
|
@Rubaiyat-E-Mohammad Do an overall test of license checking/license expiration date/license action (regular license related stuff). If all good, please mark the PR as QA passed. |
Rubaiyat-E-Mohammad
added
QA Approved
Rubaiyat-E-Mohammad
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the error handling mechanisms within the License.php file of the Appsero client. The changes ensure that API calls to the license server are more robust and reliable. Here are the key updates:
WP_Error Integration: The send_request method now returns WP_Error objects, providing more detailed error information.
Error Handling Consistency: Error responses are now consistently handled across different methods, such as activate, deactivate, and check_license_status.
Improved User Feedback: Error messages are more informative, ensuring users receive clear communication in case of issues.
The modifications enhance the overall stability and user experience of the Appsero client’s licensing functionality.
How to Test this PR
Turn off the internet from your local machine, this will simulate a CURL error.
Before Changes
After Changes