Merge pull request #125 from Appsilon/fix-404-issue

Fix 404 issue
Appsilon · Mar 24, 2023 · 7ecc3d2 · 7ecc3d2
2 parents e36697b + 85741fe
commit 7ecc3d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: shiny.router
 Type: Package
 Title: Basic Routing for Shiny Web Applications
-Version: 0.3.0
+Version: 0.3.0.9000
 Authors@R:
   c(
     person("Ryszard", "Szymański", email = "[email protected]", role = c("cre", "aut")),

diff --git a/R/router.R b/R/router.R
@@ -123,7 +123,7 @@ create_router_callback <- function(root, routes = NULL) {
       ignoreInit = FALSE,
       # Shiny uses the "onhashchange" browser method (via JQuery) to detect
       # changes to the hash
-      eventExpr = c(get_url_hash(session), session$clientData$url_search),
+      eventExpr = c(get_url_hash(session), session$clientData$url_search, input$routes),
       handlerExpr = {
         log_msg("hashchange observer triggered!")
         new_hash <- shiny::getUrlHash(session)
@@ -141,6 +141,7 @@ create_router_callback <- function(root, routes = NULL) {
         parsed$path <- ifelse(parsed$path == "", root, parsed$path)
 
         is_path_valid <- if (is.null(routes)) {
+          shiny::req(input$routes)
           log_msg("Valid paths:", input$routes)
           !is.null(input$routes) && !(parsed$path %in% c(input$routes, "404"))
         } else {