Skip to content

Commit

Permalink
fix: resolve PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
anirbanshaw24 committed Sep 12, 2023
1 parent 42b8246 commit f6d94b3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 13 deletions.
11 changes: 3 additions & 8 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
# shiny.router (development version)
# shiny.router 0.3.1

- Changed the dots (`...`) argument in `router_ui()` to allow dynamically passed arguments
- Fixed the issue where the 404 page was not working when a non-valid page is opened as the first page

# shiny.router 0.3.0

- Added a new API that is compatible with Rhino
- `router_ui` and `router_server` replaced `make_router`
- `router_ui` should be applied inside the UI function (not outside, like `make_router`) and thanks to that, can utilize `ns()` if used in a Rhino app
- `router_server` adds all required server components (mostly `observeEvents`) to the server part of the application
- Marked `make_router` as deprecated, it is not removed
- Added a new API that is compatible with Rhino. New functions `router_ui` and `router_server` are added. `make_router` is deprecated.

# shiny.router 0.2.3

- Applied `shiny::createWebDependency()` before `renderDependencies()`
- Fixed error with `shiny.router::disable_bootstrap_on_bookmark()` when used with development version of shiny by applying `shiny::createWebDependency()` before `renderDependencies()`
- Fixed `disable_bootstrap_on_bookmark()` errors with the development version of Shiny
- Fixed the issue displaying the main page bookmark on app start

Expand All @@ -27,7 +23,6 @@ No changes.

# shiny.router 0.2.0

- Introduced a new version of the router
- Remembered page state
- Stopped re-rendering the whole page every time the URL was changed
- Added support for URLs with query strings preceding hashbang
Expand Down
10 changes: 5 additions & 5 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
AGPL
Analytics
Appsilon
appsilon
CMD
Rhinoverse
RStudio
UI
appsilon
codecov
config
cranlogs
Expand All @@ -21,12 +24,9 @@ navbar
param
params
repo
Rhinoverse
rlang
RStudio
rstudio
subpages
UI
ui
webapp
www
www

0 comments on commit f6d94b3

Please sign in to comment.