-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of dynamic dots in router_ui
#126
Conversation
router_ui
router_ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is a nice improvement to the package. Some changes are required, but rather minor ones. Also, please update the package version in the DESCRIPTION.
R/router.R
Outdated
#' @param ... <[`dynamic-dots`][rlang::dyn-dots]> | ||
#' All other routes defined with shiny.router::route function. | ||
#' It's possible to pass routes in dynamic way with dynamic dots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the beginning (<[
dynamic-dots][rlang::dyn-dots]>
). Instead, after mentioning the possibility to use dynamic dots please:
- provide a link to
rlang
documentation with dynamic dots explanation - mention the example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, should I somehow add the link to the file in examples/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
...
argument inrouter_ui
to allow dynamically pass arguments